I40KG icon indicating copy to clipboard operation
I40KG copied to clipboard

Revision of hierarchy classes naming

Open mmaltsev opened this issue 6 years ago • 5 comments

Recently I noticed that some of the hierarchy classes in the STO have different names but seem to describe same things, e.g. rami:LifecycleStatus, rami:LifeCycle_Status and rami:Lifecycle_Status. Therefore, I propose to conduct a careful revision of the classification names and decide on some uniformed naming in each case.

Below, there is a full list of classes which names seemed suspicious for me:

sto:Product
sto:Prodcut

rami:LifecycleStatus
rami:Lifecycle_Status
rami:LifeCycle_Status

rami:Asst
rami:Asset
rami:Assest

rami:safety
rami:Safety

rami:Communication
rami:Communications

rami:ConditionMonitoring
rami:Conditional_Monitoring


rami:AdminShellGeneral
rami:GeneralAdminShell

rami:WorkCenter
rami:Work_Centers

mmaltsev avatar May 12 '18 18:05 mmaltsev

This is definitely a problem of typing. Can you fix them? Or point the specific lines where you find these errors?

igrangel avatar May 25 '18 12:05 igrangel

I can defenetly fix them, the only problem is to agree on some uniformed naming. Should we use a CamelCase or an underscore _ to separate words, should the terms be only in singular or only in plural? We can start from figuring out, which one is correct in this case:

rami:WorkCenter
rami:Work_Centers

mmaltsev avatar May 25 '18 14:05 mmaltsev

This is already decided. The ontology is made by following the CamelCase convention. Based on this fact, the other will be errors in typing. When you fix them, please add the links for me to check it.

igrangel avatar May 25 '18 15:05 igrangel

The naming for classes, object and data properties should follow the CamelCase notation. @sebbader, can you fix this, e.g., like in this class?

igrangel avatar Jul 26 '18 05:07 igrangel

Should be fixed with this commit

sebbader avatar Jul 26 '18 15:07 sebbader