react-tags icon indicating copy to clipboard operation
react-tags copied to clipboard

suggestion: use React memo on Input, Suggestion and Tags to avoid re render

Open rrfaria opened this issue 2 years ago • 2 comments

I noticed every single time there is a blur event even if nothing is changed All componentes are rendered again

to avoid it you can use React.memo. It will memoize properties and only will render again if any property changes

you can add it to: Input, Suggestions and Tag component

import React from 'react'

class Input extends React.Component {
 // implementation ....
 
}
export default React.memo(Input)

you can check re render by using react dev tools image and enable highligh updates image

rrfaria avatar Jun 12 '22 02:06 rrfaria

Yes it is re-rendering too often.

crazyyi avatar Jul 16 '22 18:07 crazyyi

@i-like-robots Have added it, please review my PR: https://github.com/i-like-robots/react-tags/pull/270

hritikb27 avatar Aug 31 '22 07:08 hritikb27