redbox icon indicating copy to clipboard operation
redbox copied to clipboard

Feature/redbox 234 keep deleted file django reference

Open rachaelcodes opened this issue 1 year ago • 1 comments

Context

After discussion with the wider product team about managing deleted documents, we decided to keep a reference to files in the Django database when the files were deleted from S3 and the core_api.

Changes proposed in this pull request

Now when a user chooses to delete an object, we delete the file from S3 rather than the whole Django object.

This also updates the UI with an interim version to show that the file is in a 'deleted' state. Screenshot 2024-05-23 at 15 48 12

Guidance to review

Run locally, including the database migrations (check nothing broken) - you might need to make reset-db before switching to a different branch. Try deleting a file and check how it displays - see if it deleted in minio.

Relevant links

https://technologyprogramme.atlassian.net/browse/REDBOX-234

Things to check

  • ~[ ] I have added any new ENV vars in all deployed environments~
  • [x] I have tested any code added or changed
  • ~[ ] I have run integration tests~

rachaelcodes avatar May 23 '24 14:05 rachaelcodes

Probably worth merging main in again and running make format lint.

brunns avatar May 24 '24 08:05 brunns