bee-agent-framework icon indicating copy to clipboard operation
bee-agent-framework copied to clipboard

Feat/docs

Open eduardconstantin opened this issue 1 year ago • 8 comments

Which issue(s) does this pull-request address?

Closes: #74

Description

Added index.html to docs folder to render documentation using docsify. Added Readme.md as homepage. Added _sidebar.md to have a custom sidebar. This are the deployment steps from docsify docs: https://docsify.js.org/#/deploy image image image

Checklist

  • [x] I have read the contributor guide
  • [x] Linting passes: yarn lint or yarn lint:fix
  • [x] Formatting is applied: yarn format or yarn format:fix
  • [x] Unit tests pass: yarn test:unit
  • [x] E2E tests pass: yarn test:e2e
  • [ ] Tests are included
  • [x] Documentation is changed or added
  • [x] Commit messages and PR title follow conventional commits

eduardconstantin avatar Oct 10 '24 17:10 eduardconstantin

@Tomas2D I added the action, I used this: https://github.com/marketplace/actions/docsify-action?version=v1.1 I also updated the sidebar image Also could you add the hacktoberfest label to the pr?

eduardconstantin avatar Oct 11 '24 16:10 eduardconstantin

ensures that formatting [!NOTE] / [!TIP] and renders correctly because, from the provided screenshots, it does not. image

it seems that docsify needs pulgins to format different tags

eduardconstantin avatar Oct 11 '24 16:10 eduardconstantin

Note: the hacktoberfest label is attached to the related issue; isn't that sufficient?

You will have to add it to the PR too and me as the asignee.

eduardconstantin avatar Oct 11 '24 16:10 eduardconstantin

  • [ ] It makes sense to leverage https://github.com/docsifyjs/docsify-cli so we could develop the docs in the watch mode (update docs:build script and add docs:watch) - I added the docs:watch script, I don't know what to add to build
  • [ ] auto copy README.md to docs/README.md as part of the docs:build - The links insed the readme file needs to be changed once the file is copied to the docs folder, but this step happened during docsify init command, if you call this command it will override the readme.md and index.html files (the index now has plugins added inside)
  • [x] ensures that all code snippets are rendered correctly
  • [x] ensures that all links will point to the https://i-am-bee.github.io/bee-agent-framework/ (if not developed locally)
  • [x] ensures that formatting [!NOTE] / [!TIP] and renders correctly because, from the provided screenshots, it does not.
  • [x] ensures that pipelines are passing (DCO / Lints)

eduardconstantin avatar Oct 13 '24 07:10 eduardconstantin

I added the docs:watch script, I don't know what to add to build

docsify generate ?

Tomas2D avatar Oct 13 '24 08:10 Tomas2D

I added the docs:watch script, I don't know what to add to build

docsify generate ?

this command only generates the _sidebar.md file image

if I add the init command it will override the index and the readme

eduardconstantin avatar Oct 13 '24 09:10 eduardconstantin

This signing-off thing is awful

eduardconstantin avatar Oct 13 '24 15:10 eduardconstantin

image Also fixed the rest of the issues

eduardconstantin avatar Oct 14 '24 15:10 eduardconstantin

oh, yeah, sorry

eduardconstantin avatar Oct 15 '24 16:10 eduardconstantin

I tried with this command but I get conflicts from your commits git rebase -i HEAD~47

eduardconstantin avatar Oct 15 '24 17:10 eduardconstantin

No problem, I will do it by myself. Thank you for your contribution.

Tomas2D avatar Oct 15 '24 20:10 Tomas2D