Tiger Xu / Zhonghu Xu

Results 370 comments of Tiger Xu / Zhonghu Xu

I would like to dig more on how to optimize it if this is not urgent

I have tested with https://github.com/istio/istio/issues/40952#issuecomment-1246698194 What regression do you mean?

@ramaraochavali see this comment https://github.com/istio/istio/issues/40952#issuecomment-1247866691 i figured out

>The intent is that sidecar scope only sees 1 Service per hostname. Why, in the issue case, it should see two services with same hostname but in different nses

DR selection is very related to proxy namespace and service namespace, I am concerned if changing this could introduce other regresssions

@howardjohn WDYT about dr selection?

Previously, we donot use sidecar scope for gateway, should we make gateway behave differently with sidecar?

>Is that how it worked in 1.13.2? I thought we have been using sidecar scope for gateway much before that? Yes, I am super sure, because I tested different commits...

@howardjohn @GregHanson We need to come to a consensus on this, otherwise, my work is a waste.

TBH, it is also weird for a gateway to see multi services with same hostname in different namespaces. With that, user define a vs bound to the gateway, and traffic...