ECCV2022-RIFE icon indicating copy to clipboard operation
ECCV2022-RIFE copied to clipboard

Errors when using fp16-mode with high resolutions

Open cheesywheesy opened this issue 4 years ago • 3 comments

Hi Hzwer, thanks for your work! When interpolating resolutions larger than FullHD (WQHD or UHD) in fp16 mode, i'm getting strange errors on the right half and the bottom of the interpolated frames (see example). The parsed, original frames are ok. Without fp16 or smaller resolutions everything is ok, too. I tested a bit and the error seems to occur for every pixel with one of its indices greater than 2000. Even if I crop the height to say 200 pixels, the right half is still buggy. As a workaround I split my images in 4 tiles (with some padding) an combine the interpolated tiles later. But this is obviously not ideal. If this is related to precision errors, how could it be dependant of the position of the pixel / size of the array? Isn't the fp16 math identical for every entry/pixel? Is there any fix possible? I would love to benefit from my tensor cores (rtx 3090). Btw. im on v3.8, but the error was present before.

Thanks a lot!

4k_error

cheesywheesy avatar Aug 05 '21 12:08 cheesywheesy

Thank you very much for your feedback. I think this may require retraining the model. I will learn how to train the fp16 model.

hzwer avatar Aug 06 '21 03:08 hzwer

Thank's, I look forward to the retrained model. Would be great if it works, because the fp16 speed is phenomenal (~x4).

------ Originalnachricht ------ Von: "hzwer" @.> An: "hzwer/arXiv2020-RIFE" @.> Cc: "cheesywheesy" @.>; "Author" @.> Gesendet: 06.08.2021 05:10:14 Betreff: Re: [hzwer/arXiv2020-RIFE] Errors when using fp16-mode with high resolutions (#188)

Thank you very much for your feedback. I think this may require retraining the model. I will learn how to train the fp16 model.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hzwer/arXiv2020-RIFE/issues/188#issuecomment-893968768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVDEBNYBHPXWU577AGA7K4LT3NHBNANCNFSM5BTZXTBQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

cheesywheesy avatar Aug 06 '21 09:08 cheesywheesy

fp16 does not work with newer models.

n00mkrad avatar Aug 21 '21 10:08 n00mkrad