MetaHookSv icon indicating copy to clipboard operation
MetaHookSv copied to clipboard

[CM] Persistent messages in some cases

Open di57inct opened this issue 3 years ago • 10 comments

No idea what triggers the bug, probably wrong duration identification. Reconnecting/starting a new map fixes the bug. Dictionary entries can be found at: https://github.com/hzqst/MetaHookSv/issues/188

https://user-images.githubusercontent.com/3608544/189216029-722c1d1d-b663-4877-acd5-b3d2d77ae477.mp4

di57inct avatar Sep 08 '22 20:09 di57inct

what bug?

hzqst avatar Sep 09 '22 03:09 hzqst

Permanent CaptionMod messages.

di57inct avatar Sep 09 '22 05:09 di57inct

Probably because you just connected to a server with sv.time(server living time) smaller than the previous joined server, in that case the subtitle lines that spawned from the previous server will not retire until cl.time(current client time) > the previous server's sv.time. This is because the retirement of subtitles relies on cl.time (current client time), and client time relies on sv.time (server time).

hzqst avatar Sep 09 '22 06:09 hzqst

A practical mitigation is to clear all existing subtitles on connecting. Should have been done in the latest commit

hzqst avatar Sep 09 '22 06:09 hzqst

As far as i remember i reconnected to the same server via retry command.

di57inct avatar Sep 09 '22 09:09 di57inct

As far as i remember i reconnected to the same server via retry command.

Should have been fixed in https://github.com/hzqst/MetaHookSv/releases/tag/v202209092

Subtitles are cleared when connect to a new server or retry

hzqst avatar Sep 09 '22 09:09 hzqst

Will try as soon as i get the chance. Needs a bunch of testing since it doesn't always happen. Will come back with a reply when i get to a conclusion.

di57inct avatar Sep 09 '22 09:09 di57inct

Not fixed. Server changed map, messages remained.

https://user-images.githubusercontent.com/3608544/189477800-e2f489f5-7fa8-4684-8f0f-1ac76776e69d.mp4

di57inct avatar Sep 10 '22 09:09 di57inct

Probably because I forgot to call VidInit for SubtitlePanel Should have been fixed in https://github.com/hzqst/MetaHookSv/releases/tag/v20200910

hzqst avatar Sep 10 '22 09:09 hzqst

Problem still present with latest version. Happened after server map change.

di57inct avatar Sep 28 '22 09:09 di57inct

Closing this as fixed via https://github.com/hzqst/MetaHookSv/releases/tag/v20230314a until proven otherwise and reopening later if necessary.

di57inct avatar Mar 16 '23 17:03 di57inct