Hui Zhou
Hui Zhou
Hi Jeff, thanks for the PR. Those are good fixes. Could you appease the spelling tsar and whitespace checker? They are a bit draconian to occasional contributors but do serve...
@jeffhammond The way our CI checker works (per commit check), you have to squash the fixup commits in order for them to pass.
Try use `maint/code-cleanup.bash [the_source_file] ` to clean up the white space.
test:mpich/ch3/most test:mpich/ch4/most ✔️
@jeffhammond We are still waiting for the contribution agreement before we can merge the code. We will accept an individual agreement if your company is ok with it.
> Apparently this is a feature that Intel MPI supports by passing -i8 to mpif90. Note that MPICH can be built with either default INTEGER size 4 or INTEGER size...
I don't disagree 😄 But it's quite a chore. If enough people are interested in this, it can be more motivated.
We should move https://github.com/pmodels/mpich/blob/68a6cd0b3e63914e55ac0f4e33d8abbe7f4fb904/configure.ac#L2921 into https://github.com/pmodels/mpich/blob/68a6cd0b3e63914e55ac0f4e33d8abbe7f4fb904/configure.ac#L2767-L2779
I think setting `CFLAGS` is an okay solution. The only effect is to have the header files in the specified folder to take priority, and that is the exact intention...
Yeah, if the C and Fortran compilers are from the same vendor, it will be easy for the vendor to make sure the inter-op works. Adding some instructions in README...