magento2-hyva-admin icon indicating copy to clipboard operation
magento2-hyva-admin copied to clipboard

Published 20 hours ago • verified publisher icon hyva-themes

Magento 2.3.x and below doesn't support anonymous classes

Open indefinitedevil opened this issue 4 years ago • 1 comments

Fixed in https://github.com/magento/magento2/commit/e165d99f5994af39d49ed70155c003745158e5db#diff-eac375a5ebf2447976201de8fbe0bd0d04ce9798bc0e49c573e8d755317dac22

Basically, as it stands, the DI compiler for versions below 2.4.0-p1 doesn't support anonymous classes and so any compilation which uses Hyva Admin will fail due to the anonymous classes used in the factory models.

indefinitedevil avatar May 17 '21 16:05 indefinitedevil

Thanks for bringing this up, @indefinitedevil I'd be willing to merge a PR that extracts all anonymous classes into named classes, but at the moment I don't have time to do it myself at the moment. My first priority in my open source time is to get admin forms support working. After that I would circle around to this issue if no one has beaten me to it by then.

Vinai avatar May 19 '21 08:05 Vinai