hyva-coding-standard icon indicating copy to clipboard operation
hyva-coding-standard copied to clipboard

Published 20 hours ago • verified publisher icon hyva-themes

Updated magento-coding-standard for mimimum requirement magento 2.4.6

Open rakibabu opened this issue 1 year ago • 3 comments

rakibabu avatar Mar 16 '23 09:03 rakibabu

Thanks for the PR! Could you please summarize the differences and why it us better now?

Vinai avatar Mar 16 '23 09:03 Vinai

Hi Vinai,

This change is only in the composer.json to not lock the magento/magento-coding-standard version to 25. Magento 2.4.6 uses version 31.

rakibabu avatar Mar 17 '23 09:03 rakibabu

Hi @rakibabu - thanks, that much is clear.
I was asking about the differences between v25 and v31. From my side there is no necessity to have the Hyvä coding standard follow the Magento one during upgrades.

Rather than blindly include any changes that Adobe makes, I would much rather choose if the changes are actually an improvement, and also check if they cause existing Hyvä code to no longer pass.

If you could summarize the changes between v25 and v31 of the Magento coding standard that would be helpful. Otherwise I'll check it out when I have time.

Vinai avatar Mar 17 '23 14:03 Vinai