bytesize icon indicating copy to clipboard operation
bytesize copied to clipboard

Fix #26 LN_KIB / LN_KB are backwards

Open ChanTsune opened this issue 2 years ago • 2 comments

Hi @hyunsik

I found that part of #33 can solve #26, so I made this PR.

This change causes no problems for the most part, but I am making changes to the existing test cases just because they are affected by #26.

This change will also help #3

ChanTsune avatar Aug 24 '23 13:08 ChanTsune

I'm sorry for a late review. I'll review asap by this week.

hyunsik avatar Sep 06 '23 00:09 hyunsik

@ChanTsune, the problem is that not only LN_KIB & LN_KB have each other's values, but SI conditions are also inverted. I made a PR (#38) which fixes the whole "inverted thing" and now if SI condition is true it will show SI unit instead of IEC. It probably would be the best if #38 is merged first and then, with small tweaks (but the main logic change intact), #26.

Andrew15-5 avatar Oct 06 '23 17:10 Andrew15-5