bytesize icon indicating copy to clipboard operation
bytesize copied to clipboard

SI unit should be decimal units

Open EFanZh opened this issue 3 years ago • 1 comments

Currently, the effect of the si_unit argument of ByteSize::to_string_as seems to be reversed. According to Wikipedia, SI units are decimal units, and IEC units are binary units.

EFanZh avatar Apr 11 '21 06:04 EFanZh

I highly recommend using an enum with SI and IEC variants instead of a bool, as this is so much clearer in code.

wookietreiber avatar Apr 15 '21 07:04 wookietreiber