hyrise-v1 icon indicating copy to clipboard operation
hyrise-v1 copied to clipboard

Published 20 hours ago • verified publisher icon hyrise

Store::isVisibleForTransaction is misleading

Open mrks opened this issue 10 years ago • 3 comments

Store::isVisibleForTransaction does not check if a row has been deleted by a transaction. While ValidatePositions does a check based on the modification list, a user might assume that isVisibleForTransaction is also covering that case.

mrks avatar Apr 07 '14 22:04 mrks

Suggestion? Add a comment regarding this? I'll also take naming suggestions.

bastih avatar Apr 07 '14 22:04 bastih

Correct me if I'm mistaken, but can't we cover that case by simply negating the result of the CID checks if tidVector[row] == tid?

mrks avatar Apr 07 '14 22:04 mrks

That method used to be way better documented than it is right now. I'll check that in the morning.

bastih avatar Apr 07 '14 22:04 bastih