Hyprland icon indicating copy to clipboard operation
Hyprland copied to clipboard

Only notify if something fails - `hyprpm reload -n`

Open KAGEYAM4 opened this issue 1 year ago • 2 comments
trafficstars

Description

In the --help it says --notify | -n → Send a hyprland notification for important events (e.g. load fail) but it's also generating on success.

image

https://github.com/hyprwm/Hyprland/blob/1822707c7e7394ce8c7572f2fe890763a307f499/hyprpm/src/main.cpp#L145-L159

KAGEYAM4 avatar Oct 13 '24 09:10 KAGEYAM4

@vaxerski any thoughts. pass & fail are mutually exclusive. No need to notify for both cases.

I don't think anything needs to be changed for hyprpm --help as -n -> Send a hyprland notification for important events (e.g. load fail) seems to states that it will only send important events like failing.

KAGEYAM4 avatar Oct 18 '24 11:10 KAGEYAM4

no it just gives an example. This is a fair request tho, MRs welcome

vaxerski avatar Oct 18 '24 18:10 vaxerski