Hyprland icon indicating copy to clipboard operation
Hyprland copied to clipboard

feat: dispatchers, add hidespecialworkspace

Open Bartkk0 opened this issue 1 year ago • 7 comments

Describe your PR, what does it fix/add?

Adds a dispatcher hidespecialworkspace that hides the current special workspace

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I don't think so

Is it ready for merging, or does it need work?

I think it's ready for merging

Bartkk0 avatar Jul 13 '24 10:07 Bartkk0

Hide as in, don't show the special workspace anymore or hide as in, make it inaccessible?

Eclextic avatar Jul 13 '24 11:07 Eclextic

Hide as in, don't show the special workspace anymore or hide as in, make it inaccessible?

Hide as in don't show it anymore

Bartkk0 avatar Jul 13 '24 12:07 Bartkk0

i think it would make more sense to add an arg to togglespecialworkspace (like 0/1/toggle) or create a new dispatcher that could open, close and toggle instead of creating one just to close it also vaxry will want a wiki MR

MightyPlaza avatar Jul 13 '24 12:07 MightyPlaza

mightyplaza is right on both fronts

vaxerski avatar Jul 13 '24 18:07 vaxerski

i think it would make more sense to add an arg to togglespecialworkspace (like 0/1/toggle) or create a new dispatcher that could open, close and toggle instead of creating one just to close it also vaxry will want a wiki MR

Yeah I agree, that's what confused me a bit... The togglespecialworkspace functionality closely resembles what you are trying to do, so it should probably become an argument.

Also I can't think of a case where anyone would need to just close the special workspace instead of toggling it...

Eclextic avatar Jul 13 '24 20:07 Eclextic

for me the use case is to hide the currently visible special workspace, togglespecialworkspace could have an additional argument, but it would also need to handle referring to the current workspace

Bartkk0 avatar Jul 13 '24 20:07 Bartkk0

Always hiding the special workspace would be useful for making it so that when you switch to a workspace the special workspace always hides

I currently use this bound to every single workspace hotkey for this and it'd certainly simplify that

hyprctl monitors -j | jaq -r '.[] | select(.focused == true) | .specialWorkspace.name' | sd 'special:' '' | xargs -I [] hyprctl dispatch togglespecialworkspace []

Kommynct avatar Jul 14 '24 03:07 Kommynct

#8594 provides alternative solutions which may be of use.

dxrcy avatar Nov 28 '24 01:11 dxrcy

closing due to inactivity

vaxerski avatar Apr 08 '25 13:04 vaxerski