Hyprland icon indicating copy to clipboard operation
Hyprland copied to clipboard

crash when hovering over tooltips in certain firefox extensions

Open olifloof opened this issue 2 years ago • 30 comments

hyprland.log.txt Please consult the issue guidelines at https://github.com/vaxerski/Hyprland/blob/main/docs/ISSUE_GUIDELINES.md BEFORE submitting.

olifloof avatar Aug 29 '22 08:08 olifloof

should I also dump core?

olifloof avatar Aug 29 '22 08:08 olifloof

yes

vaxerski avatar Aug 29 '22 08:08 vaxerski

https://gist.github.com/pinkcreeper100/05eb17f0c039d162b2cf209515f94038

olifloof avatar Aug 29 '22 09:08 olifloof

thats the log, not the coredump

vaxerski avatar Aug 29 '22 09:08 vaxerski

oop

olifloof avatar Aug 29 '22 09:08 olifloof

https://easyupload.io/5wvrs3

olifloof avatar Aug 29 '22 09:08 olifloof

how is that 300MB???

Please follow the instructions in the guidelines you've even linked yourself.

vaxerski avatar Aug 29 '22 09:08 vaxerski

hlcd.txt

olifloof avatar Aug 29 '22 14:08 olifloof

image dunno works for me. Any step-by-step instructions? (may I remind you I will not sign up / pay just to test something)

vaxerski avatar Aug 29 '22 14:08 vaxerski

  1. be logged in
  2. edit an already created item or create a new item
  3. hover over the different buttons in the password section repeatedly until it crashes

olifloof avatar Aug 29 '22 14:08 olifloof

How often does this occur? I can't seem to repro on my machine hovering over the Check if password has been exposed and Generate Password buttons repeatedly. I do notice the window flickering sometimes, which is odd.

TheSunCat avatar Sep 02 '22 14:09 TheSunCat

on my end, the window has to flicker at least around 5 times for a crash to occur but maybe more idk

olifloof avatar Sep 04 '22 07:09 olifloof

Also occurs with uBlock origin

olifloof avatar Sep 09 '22 19:09 olifloof

I am able to reproduce the same crash with uBlock origin and other extensions. This is with MOZ_ENABLE_WAYLAND=1. From the extension's menu (like in the image above), simply hovering over buttons that have title/tooltip text enough times will trigger it (typically 3-10 hovers in my case). For me, flickering does occur but seems to not be necessary to trigger the crash (probably just a symptom).

IanManske avatar Sep 12 '22 19:09 IanManske

check with e518adf1ac3db14e85fd3b8ceab71c22eab9d1c7

vaxerski avatar Sep 13 '22 13:09 vaxerski

Crash still exists :(

IanManske avatar Sep 13 '22 17:09 IanManske

dump gib

vaxerski avatar Sep 13 '22 17:09 vaxerski

in class lol one sec

IanManske avatar Sep 13 '22 17:09 IanManske

That was more than one sec, sorry for the wait. Not sure if I did it correctly (there's some n\a's in the dump). dump.txt

IanManske avatar Sep 13 '22 18:09 IanManske

I am pretty sure this is the wrong dump.

vaxerski avatar Sep 13 '22 18:09 vaxerski

but fixed that crash in da10022d846334fe4265ec03b44a75c41921f603

vaxerski avatar Sep 13 '22 18:09 vaxerski

Uhhh correct me if I'm doing something dumb.

  1. clone the repo and cd
  2. sudo make clear
  3. sudo make config
  4. make debug
  5. open separate tty
  6. cd $repo/build
  7. run Hyprland -c ../example/hyprland.conf
  8. reproduce the crash
  9. coredumpctl and get pid of last Hyprland
  10. get dump of pid

Again in case: dump.txt

IanManske avatar Sep 13 '22 19:09 IanManske

run Hyprland -c ../example/hyprland.conf

man didnt learn bash in school ./Hyprland, not Hyprland

vaxerski avatar Sep 13 '22 19:09 vaxerski

:insert clown meme: I just forgor. It's always the smallest things... Here's the dump (hopefully): dump.txt

IanManske avatar Sep 13 '22 19:09 IanManske

#0  0x00000000004f2238 n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xf2238)
#1  0x00000000004f318e n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xf318e)
#2  0x00000000004c56fb n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xc56fb)
#3  0x00000000004c527f n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xc527f)
#4  0x00000000004c4dff n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xc4dff)
#5  0x00000000004f788d n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xf788d)
#6  0x00000000004f758d n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xf758d)
#7  0x00000000004f70c3 n/a (/home/iama/Code/Hyprland/build/Hyprland + 0xf70c3)

amazing dump. When doing a coredump of a debug build, make sure to do coredumpctl debug <pid> instead, not pipe the output, get to the gdb console (if it asks questions, enable debuginfod and continue without paging) and do bt -full

vaxerski avatar Sep 13 '22 19:09 vaxerski

Ikr! But the docs should probably be updated? Third time's the charm... dump.txt

IanManske avatar Sep 13 '22 19:09 IanManske

can you print *PNODE?

vaxerski avatar Sep 13 '22 19:09 vaxerski

Had to familiarize myself with gdb... print.txt

IanManske avatar Sep 13 '22 19:09 IanManske

really odd as this does not happen AT ALL to me, and the crash is really weird too. Can you also try running Hyprland with ASan? Sorry if I am asking for so much, I'd do it myself if not for the fact it never crashes for me.

CMakeLists.txt: line 83 (insert before the line) asan

line 93 (add to CXX_FLAGS args) -fsanitize=address

pipe the outputs of hyprland (both stdout and stderr) to a file and give me that.

vaxerski avatar Sep 13 '22 19:09 vaxerski

Yeah np, let me join the discord real quick.

IanManske avatar Sep 13 '22 20:09 IanManske