Hyprland icon indicating copy to clipboard operation
Hyprland copied to clipboard

The animation when scrolling through workspace is going into the wrong direction when going between first and last workspace

Open Azercoco opened this issue 1 year ago • 3 comments

Hyprland Version

System/Version info
Hyprland, built from branch HEAD at commit 03ebbe18ed8517ee22591eac82cd54322f42cb7d  (props: bump ver to 0.34.0).
Date: Mon Jan 1 12:03:15 2024
Tag: v0.34.0

Bug or Regression?

Bug

Description

When scrolling through the workspace using the workspace, e +/- 1 , the animation direction of going from workspace 1 to the the last is the same than going from 1 to 2. The same applies from going to the last to the first which is also reversed.

How to reproduce

  • Open at least 3 workspaces
  • Scroll between the first and the last
  • The animation is reversed which is confusing for navigation

Crash reports, logs, images, videos

No response

Azercoco avatar Jan 24 '24 20:01 Azercoco

This animation direction is intentional, as the last workspace is in the same direction as the second workspace from the perspective of the first workspace. image

As far as I understood you want the option to have the following behavior instead: image

The relevant code section determining the direction of this animation is in src/helpers/Monitor.cpp:527 in the changeWorkspace function which gets called in src/managers/KeybindManager.cpp:929. I won't implement a Pull Regest for this for now as it is quite late, but I might take another look at it tomorrow.

pdamianik avatar Feb 11 '24 00:02 pdamianik

PR draft is ready: #4684. The option is named binds:animate_workspace_band for now, but I am open for suggestions.

pdamianik avatar Feb 12 '24 10:02 pdamianik

#4684 and hyprwm/hyprland-wiki#477 are ready. I am just waiting for feedback from @Azercoco.

pdamianik avatar Feb 18 '24 16:02 pdamianik

I propose animations:workspace_wraparound instead, it's more consistent with where other workspace animation setting are configured and imo is a more straightforward name

KoyeBosh avatar Feb 28 '24 09:02 KoyeBosh

The option is now called animations:workspace_wraparound. Thanks for the suggestion @KoyeBosh.

pdamianik avatar Feb 28 '24 10:02 pdamianik