Refactor/IHprLayout

Open JassonCordones opened this issue 6 months ago • 2 comments

Describe your PR, what does it fix/add?

Split the performSnap and onMouseMove function to make it easier to test and work with.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

yes, is ready I don't want to make the PR too big

Jun 20 '25 05:06 JassonCordones

@vaxerski This refactor can be merged.

Jun 28 '25 16:06 JassonCordones

No, I don't think so. What does this refactor achieve? There are no benefits functionally, only potential (and wouldn't be the first time) regressions. You're rewriting a large part of code that has had historically dozens of small edge cases and issues, in a huge unreviewable dollop.

In general, I am not in favor of huge refactors for no gain, only because "uhh code looks complicated".

Jun 29 '25 18:06 vaxerski