Delete Via 3 feature flag

[seanh]

Confusingly this actually involves sending PRs to the LMS app, to make it use Via 3, not sending PRs to Via 3. But the issue is in the Via 3 repo so that it can go in the milestone with other Via 3 issues.

• [x] Remove all references to the use_via3_url feature flag from the LMS code
• [x] There also appears to be a reference to a use_via2_html_rewriter feature flag in the LMS code, let's remove that too
• [x] Remove the via3_url setting from LMS *.ini files and code
• Remove envvars from LMS QA and prod in Elastic Beanstalk
  • [x] FEATURE_FLAGS_ALLOWED_IN_COOKIE
  • [x] VIA3_URL

[seanh]

@jon-betts Do you know if this got done or does LMS still have a Via 3 feature flag?

[robertknight]

Remove all references to the use_via3_url feature flag from the LMS code

I found no remaining references to use_via or via3_url anywhere in the LMS code or request.feature tests for similar-sounding features.

There also appears to be a reference to a use_via2_html_rewriter feature flag in the LMS code, let's remove that too

This no longer exists.

Remove the via3_url setting from LMS *.ini files and code

There is no longer a via3_url setting in the LMS conf files or code. There is a via_url setting in conf/development.ini.

Other than the above, I did find a handful of remaining references to "Via 3" in README.markdown, tests/conftest.py and conf/development.ini.

[robertknight]

@seanh - Can this issue be closed?