lms icon indicating copy to clipboard operation
lms copied to clipboard

Work out deployment plan for VS SSO to customers

Open jon-betts opened this issue 2 years ago • 2 comments

Requires:

  • https://github.com/hypothesis/lms/issues/4215

The new work requires extra settings and fields for customers. We should know how we intend to onboard customers.

This should ensure:

  • Continuity for any existing customers - i.e. backwards compatibility (are there any customers?)
  • How we will upgrade people (does this even matter?)
  • Who will be doing this work (support?)
  • Vitalsource are happy with what we are going to put out - Wording / sign-off?
    • Are they happy for us to expand to new customers?
    • We can't without credentials Vitalsource give us, which implies sign-off

Once this is done we can immediately start gaining some value even if we are planning to refine the solution.

Questions

  • Do we need to keep backward compatibility?
  • Who are our current customers? Do we even have to worry about this?
    • Pilot customers? More detail here...

Implementation idea

  • Gather VS API keys and settings from / for the customers
    • We need a VitalSource API key
    • ... and the correct LTI param to read the user reference from (e.g. user_id)
    • ... for each application instance we need to upgrade
  • We can deploy the settings page in order to collect the required settings for customers
  • Then we can deploy the bulk of the code once the settings are in place

RISK! - You aren't going to know if a users settings work until we deploy the full code. Should we have an interstitial PR which starts using the customer key right away?

Tasks

  • [x] https://github.com/hypothesis/lms/pull/4262
  • [x] Fill out the required application instances

jon-betts avatar Jul 12 '22 15:07 jon-betts

@jon-betts what does gather user data and verify data somehow mean?

chrisshaw avatar Aug 17 '22 22:08 chrisshaw

Summary of discussion with Jon, Daryl and myself: We've implemented the code changes required to allow customers to use SSO for VitalSource. We need to check if the customers we planned to enable SSO for have it enabled. If they do, we can close this issue. If there are customers that have specific complications, we can open new issues to address those.

robertknight avatar Sep 20 '22 13:09 robertknight