h icon indicating copy to clipboard operation
h copied to clipboard

add redirect_uri and grant_type to authclient

Open bpow opened this issue 3 years ago • 6 comments

Addresses #7009, adding functionality to the cli tool that otherwise would only be possible in the web interface. Useful for scripting addition of an authclient.

bpow avatar Feb 22 '22 03:02 bpow

Re-based from current master-- realized I had based this commit from a different branch.

bpow avatar Mar 24 '22 18:03 bpow

Rebased again to the current HEAD.

Is there a better forum to request feedback/review/discussion of this fairly-constrained pull request that was first submitted 3 weeks ago to address an issue reported 6 months ago?

bpow avatar Apr 05 '22 13:04 bpow

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 06 '22 10:05 github-actions[bot]

Commenting so the "stale" label will get removed.

This issue was acknowledged/discussed briefly on slack with the suggestion to maybe work-around by creating a local equivalent of devdata.json. However, even if external developers were to create their own devdata, then they'd have to patch upstream elsewhere (since the "official" devdata repo is directly hard-coded within the python script h/cli/commands/devdata.py rather than in a configuration file.

bpow avatar May 06 '22 13:05 bpow

Issue #7009 is still active, and this is one potential approach. Please consider lengthening the auto-closing time threshold to allow core developers enough time to triage/respond to pull request like this.

bpow avatar May 12 '22 13:05 bpow

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 06 '22 10:08 github-actions[bot]

Please consider reopening, or at the very least have someone from the hypothes.is team respond rather than having this automatically closed without response. Issue #7009 remains otherwise unaddressed, and while there may be other more optimal solutions, this addresses a specific use case of staging development instances in a more automated fashion for community members who do not have access to the private development staging data repository.

On the slack, there was discussion back in May of somehow tagging pull requests from external contributors so that they would not necessarily be auto-closed for staleness, and that may be worth revisiting as well.

bpow avatar Aug 12 '22 15:08 bpow