h icon indicating copy to clipboard operation
h copied to clipboard

Fix h's Sentry noise

Open seanh opened this issue 6 years ago • 3 comments
trafficstars

We currently have 114 unresolved production h backend issues in Sentry. This is too many: we don't want any new issues created by upgrading to Python 3 to be drowned out by preexisting noise. Also we just don't want to have a lot of unresolved issues that we're ignoring (broken windows). Let's get these fixed before upgrading to Python 3.

Sentry issues that need to be fixed in prioritized order:

  • [ ] Crash when trying to create an annotation: ConcurrentUpdateError: concurrent document creation https://github.com/hypothesis/h/issues/5495
  • [ ] Crash when the client is trying to get an OAuth token: AttributeError: 'NoneType' object has no attribute 'userid' https://github.com/hypothesis/h/issues/5280
  • [ ] Group page crash (when trying to join a group, looks like) duplicate key value violates unique constraint: IntegrityError https://github.com/hypothesis/h/issues/5551
  • [x] /accounts/developer page crash: MultipleResultsFound https://github.com/hypothesis/h/issues/5552
  • [ ] URI normalization crashes when port not an int
  • [ ] Annotation create API crashes on long URLs
  • [x] WebSocket HandshakeError: HTTP method must be a GET

seanh avatar Jan 30 '19 13:01 seanh

The Sentry issue for the handling long claimant URIs issue seems to have been automatically resolved by Sentry due to inactivity ("Sentry marked this issue as resolved due to inactivity") which I didn't realise Sentry did.

seanh avatar Feb 26 '19 15:02 seanh

@hmstepanek I've updated this issue to reflect the four remaining issues we're currently seeing in Sentry. As commented above it looks like at least one issue might have been automatically resolved by Sentry though it remains an issue in the code. But as long as it doesn't reappear in Sentry I'm happy to ignore it! So let's just focus on fixing these four now

seanh avatar Feb 26 '19 15:02 seanh

I imagine it’s probably inactive because the user figured out they couldn’t annotate any of those urls so they stopped trying.

hmstepanek avatar Feb 26 '19 15:02 hmstepanek

Obsolete.

leedenison avatar Jul 05 '23 09:07 leedenison