feature_request(pdf): links to PDF support

[Kristinita]

trafficstars

1. Summary

I can't annotate any remote PDF documents, that I open in browser.

2. Argumentation

I begin to use Hyphotes.is, to conveniently save and organize the thoughts of smart people who can be useful to me in my life and work. Usually they are contained in books that have PDF or FB2 format. But at the time I can't save annotations from books.

3. Steps to reproduce

I reproduce the problem in a version of Firefox without any extensions and user settings.

I logged in Hyphotes.is → I add bookmarklet → I open any PDF document in browser, https://orgmode.org/orgguide.pdf for example → I select any text → I click to bookmarklet → Annotate.

4. Expected behavior

As for HTML pages:

5. Actual behavior

I can't create annotation:

• Firefox native console output:

TypeError: PDFViewerApplication.pdfViewer.getPageTextContent is not a function[Learn More] pdf.coffee:1
getPageTextContent
pdf.coffee:1
n
pdf.coffee:1
getPageOffset
pdf.coffee:1
[37]</exports.describe
pdf.coffee:1
n
guest.coffee:1
map self-hosted:286:17 [51]</Guest</n.prototype.createAnnotation
guest.coffee:1
onAnnotate
guest.coffee:1
r
adder.js:159:6
e/<
adder.js:165:42

6. Environment

• Firefox Quantum 64.0.2 (64-bit)

Thanks.

[pafonta]

I confirm we have also this issue on Firefox 64.0.2 and 65.0 with @elisabettai.

Could someone from Hypothesis look at this?

It is a critical issue for people using Firefox.

[dwhly]

Check on Monday. It should be resolved.

D

On Fri, Feb 1, 2019 at 8:40 AM Pierre-Alexandre Fonta < [email protected]> wrote:

I confirm we have also this issue on Firefox 64.0.2 and 65.0 with @elisabettai https://github.com/elisabettai.

Could someone from Hypothesis look at this?

It is a critical issue for people using Firefox.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hypothesis/h/issues/5502#issuecomment-459785357, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWP0npLIvqWaenu5yP8XwHLgqHAk2sxks5vJG4bgaJpZM4aEiBC .

-- +1 650 274 7647 m

[pafonta]

Thank you for your prompt reply @dwhly.

I have just check now (09:05 04.02.19 UTC) with the bookmarklet here, Firefox 65.0, PDF.js: 2.1.97, on macOS 10.13.6.

I still have the issue: TypeError: PDFViewerApplication.pdfViewer.getPageTextContent is not a function.

[robertknight]

Hello @pafonta - We haven't released the fix yet. That will happen today. What @dwhly meant above is that we will release the fix when developers get to work on Monday!

[pafonta]

Hello @robertknight. Thank you for the clarification. As he replied on what is a Saturday in my time zone I thought it would have been deployed before Monday. We have just tried on the configuration mentioned above and it works for us. Thank you very much for the fix!