client icon indicating copy to clipboard operation
client copied to clipboard

Can't open sidebar when annotation target is a link

Open dwolfe opened this issue 6 years ago • 7 comments

When an annotation targets a link, the link activates as normal, which means that we see the sidebar open just in time for the page to refresh with the new location. The only way to see such an annotation is to open the sidebar and find it there - no way to see those annotations from the text itself.

See current behavior here: http://jonudell.info/h/highlight-coincides-with-link.mp4

Steps to reproduce

  1. Browse to http://conf.a11yto.com/playlist
  2. Select "Public" from group selector if not already selected
  3. Click on any highlighted link (talk titles are good examples)

Expected behaviour

Need to figure this out - one approach might be to stop propagation of the click and show a clickable link so that it's still navigable, similar to Google Docs:

screen shot 2018-10-16 at 5 03 38 pm

Actual behaviour

Sidebar opens, but page immediately navigates to new URL.

Browser/system information

macOS Mojave/Chrome

dwolfe avatar Oct 17 '18 14:10 dwolfe

@ajpeddakotla If this is still relevant, could you open a new issue for it? Thanks!

dwolfe avatar Aug 20 '19 18:08 dwolfe

The same behavior still exists. As relevant now as it was then.

dwhly avatar Aug 20 '19 18:08 dwhly

Noted. Can you copy this into a new issue so I'm not involved? Thanks.

dwolfe avatar Aug 20 '19 19:08 dwolfe

@dwolfe could you turn off notifications for this repo rather than closing issues? Let’s not create more work when it’s not needed. Thanks!

ajpeddakotla avatar Aug 20 '19 21:08 ajpeddakotla

Other tickets: https://hypothesis.zendesk.com/agent/tickets/11025

mkdir-washington-edu avatar Jul 01 '20 15:07 mkdir-washington-edu

Wow, this issue has been there for years! One workaround is the one Michael/helpdesk gave me which is going the other direction around to find the annotation within the sidebar, not very good but is the best available so far. The other workaround is to highlight more neighbors if the target is a hyperlink. 

hcchengithub avatar Jul 04 '20 01:07 hcchengithub

Encountering this problem now. Another way that might work on mobile too might be to catch the link click and present two options to either go to the link or show the annotation similar to the way the highlight/annotate buttons appear when you highlight text?

sneakers-the-rat avatar Dec 10 '21 01:12 sneakers-the-rat