client icon indicating copy to clipboard operation
client copied to clipboard

Document scrolltorange event

Open thewilkybarkid opened this issue 7 years ago • 1 comments

https://github.com/elifesciences/pattern-library/pull/873 changes eLife to react to the scrolltorange event to open collapsed sections rather than trying to open everything when we can detect the Hypothesis client opening (which isn't entirely possible). (This was mentioned in https://github.com/hypothesis/client/issues/660#issuecomment-361976811.)

This event appears to be designed for this use case, but isn't documented anywhere (so we weren't aware of it). Could it be, so we won't have problems relying on it?

thewilkybarkid avatar Jun 08 '18 18:06 thewilkybarkid

This event appears to be designed for this use case, but isn't documented anywhere (so we weren't aware of it). Could it be, so we won't have problems relying on it?

We have tests for this behavior and rely on it in our YouTube transcript annotation UI, so I think it can be considered a stable API. It is still missing from the documentation at https://h.readthedocs.io/projects/client/en/latest/ though.

robertknight avatar Dec 19 '23 10:12 robertknight