client icon indicating copy to clipboard operation
client copied to clipboard

UI inconsistency in Group menu sub-items

Open lyzadanger opened this issue 3 years ago • 3 comments

There's an inconsistency in the hover behavior for sub-menu items in the groups menu in the client. The group-activity item is a link and is getting different cursor hover styling than the other items, which are not links.

submenu-items

The link has the default pointer style, which is correct. The actions do not, and they should also have the pointer style.

Expected

When I hover over an action, I get a pointer- styled cursor.

lyzadanger avatar Feb 04 '22 13:02 lyzadanger

@lyzadanger doesn't this actually make sense? One is an action. One is a link. What does our design language say about action buttons versus link buttons?

If anything, this seems like a complex case of a Link within a List Item component within an Accordian List pattern. And I don't see anything that would define how we handle that in the design system. But I do see link, and I do see button.

We can of course create whatever rules of meaning we want. If it's more usable to make them consistent let's do it. But I think this may actually follow common conventions to have the link styled differently.

chrisshaw avatar Feb 04 '22 17:02 chrisshaw

I'd like to have cursor:pointer on the actions if nothing else.

lyzadanger avatar Feb 04 '22 18:02 lyzadanger

Yeah that makes sense

chrisshaw avatar Feb 07 '22 02:02 chrisshaw