client icon indicating copy to clipboard operation
client copied to clipboard

Annotation from iframe does not trigger editing annotation text

Open evlibra opened this issue 4 years ago • 2 comments

Steps to reproduce

  1. Select test inside iframe
  2. Click "Annotate" 3

Expected behaviour

Annotations bar papers with editing dialog for annotation and text is highlighted after saving annotation.

Actual behaviour

Annotations bar papers but WITHOUT editing dialog for annotation

Browser/system information

Version 87.0.4280.141 (Official Build) (64-bit) (same on Firefox)

Additional details

sample page with iframe at the bottom right (e.g. for the element Connect with Floor): https://evlibra.github.io/Archi_Body/#b90805b2-7a2c-47e2-86a7-b2d5d1dd95a6

Note (workaround): if on step 2 do click Highlit - the text is hilited, and it is possible to edit its annotation. But that are extra steps - instead, annotation shall work on iframe in the same way as on its parent page

evlibra avatar Jan 20 '21 00:01 evlibra

If I understand correctly @evlibra you are trying to make use of the client's ability to automatically enable annotation for same-origin iframes that have the enabled-annotation attribute per https://h.readthedocs.io/projects/client/en/latest/publishers/embedding/#enabling-annotation-of-iframed-content?

If so, then I see indeed that selecting text in the right-hand iframe (labeled "Front Awareness") on https://evlibra.github.io/Archi_Body/#b90805b2-7a2c-47e2-86a7-b2d5d1dd95a6 is not working as it should.

robertknight avatar Mar 18 '21 10:03 robertknight

@robertknight , I believe your understanding is correct. Please advise if when the issue can be fixed? Thanks for your response!

evlibra avatar Mar 19 '21 03:03 evlibra