client icon indicating copy to clipboard operation
client copied to clipboard

editor toolbar scrolls on windows 10 2nd monitor

Open judell opened this issue 4 years ago • 2 comments

See https://jonudell.info/h/editor-toolbar-scroll-behavior.mp4

image

This does not happen on the primary monitor, only the secondary.

/cc @klemay

judell avatar Mar 31 '20 18:03 judell

@judell is your 2nd monitor a touch screen? or does your browser potentially "think" it is? in today's backlog review @robertknight mentioned the client relies on info from the browser when determining whether to display the scroll bar or not

klemay avatar Apr 01 '20 17:04 klemay

The second monitor is not a touch screen, but yeah, I guess the browser thinks it is.

This became so annoying today that put this fix into my local extension, which removes the following from sidebar.css.

/*
@media (pointer: coarse) {
  .markdown-editor__toolbar {
    padding: 0;
    padding-bottom: 10px;
    flex-wrap: unset;
    overflow-x: scroll;
  }

  .markdown-editor__toolbar-button {
    min-width: 44px;
    min-height: 44px;
  }
*/

judell avatar Aug 28 '20 19:08 judell

As noted above, we rely on the browser to tell us whether the device is a touch screen or not and adjust the size/hit targets of buttons accordingly. If the browser is providing incorrect information for any reason, I would suggest to create a minimal test case using @media (pointer: coarse) queries and take it up with them.

robertknight avatar Sep 22 '23 13:09 robertknight