hypothesis
Annotation share dialog can get stacked under top bar
If you create a page note with a very short body, so that there is only one line of regular text rendered, then the "Share annotation" button is close enough to the top of the sidebar that clicking on it shows a panel which appears underneath the top navigation bar:
There is enough vertical space that the popup would be fully visible if it appeared above the top bar.
I can still reproduce this, but it is less of an issue given other UI changes:
Two possible solutions:
- Change the stacking order so that the panel is above the top bar
- Change the panel to show below the button if there is not enough space above
- Make share panel always fit beneath top bar (again).
This is how it "used to be." My hunch is that consolidation of spacing/padding in the newer shared components is more "spacey", allowing this component to ever be tall enough to be obscured by the top bar. Previously it was sized such that this could never happen in the minimal annotation-card-height situation (as you've captured here).
Related to https://github.com/hypothesis/client/issues/1738
We may want to consider "opening down" when the annotation share control is activated near the top of the screen.