social.distributed.press icon indicating copy to clipboard operation
social.distributed.press copied to clipboard

fix: parse object.id in performUndo() and add tests

Open magush27 opened this issue 1 year ago • 7 comments

Fixed issue https://github.com/hyphacoop/distributed-press-organizing/issues/150

magush27 avatar Jun 26 '24 23:06 magush27

@RangerMauve I asked Agus about this and they said this is done and awaiting for your ok. Let us know how you see it. If it's done, I have to close this PR as well as issue 150 https://github.com/hyphacoop/distributed-press-organizing/issues/150

sutty-coop avatar Jul 15 '24 13:07 sutty-coop

@RangerMauve I asked Agus about this and they said this is done and awaiting for your ok.

Let us know how you see it. If it's done, I have to close this PR as well as issue 150 https://github.com/hyphacoop/distributed-press-organizing/issues/150

Hey, don't close this PR, it's not merged yet. I've requested some changes.

Ping @magush27

akhileshthite avatar Jul 15 '24 14:07 akhileshthite

@magush27 the tests aren't passing, mind fixing them? Seems you're missing a function

RangerMauve avatar Jul 17 '24 20:07 RangerMauve

@magush27 the tests aren't passing, mind fixing them? Seems you're missing a function

yes, I'm on this right now

magush27 avatar Jul 18 '24 14:07 magush27

@RangerMauve the tests works well on push and in my local computer but not on pull_request, what is the problem?

magush27 avatar Jul 19 '24 19:07 magush27

@RangerMauve the tests works well on push and in my local computer but not on pull_request, what is the problem?

Hey, update your node version to 19.9.0 to resolve those gh action errors :)

akhileshthite avatar Jul 20 '24 20:07 akhileshthite

Ah, yeah merge the latest main branch into this.

git pull origin/main should do the trick

RangerMauve avatar Jul 22 '24 16:07 RangerMauve

@RangerMauve @akhileshthite i merged main!

fauno avatar Aug 23 '24 17:08 fauno