react-date-range icon indicating copy to clipboard operation
react-date-range copied to clipboard

All the dates are selected in date range picker when setting startDate and endDate null or empty

Open manishg345 opened this issue 4 years ago • 8 comments

Subject of the issue

All the dates are selected in date range picker when setting startDate and endDate null or empty

[BUG] Bug Reproduce Steps

In DateRangePicker state object, set startDate and endDate as null

[BUG] Expected behaviour

Initially when both of the date textfields are set as blank, none of the date should be selected in the calendar of DRP

Environment

Package Version: React version: Node version: Browser:

manishg345 avatar Mar 25 '20 14:03 manishg345

+1

shaohuahuang avatar Apr 01 '20 03:04 shaohuahuang

+1

ao-alex avatar Sep 04 '20 14:09 ao-alex

+1, every day gets the rdrInRange class, which just doesn't make sense.

fsdiogo avatar Oct 26 '20 12:10 fsdiogo

Noted the same / similar issue in https://github.com/hypeserver/react-date-range/issues/330#issuecomment-721482829 with some demos there.

gaieges avatar Nov 04 '20 03:11 gaieges

To work around this I added a class rdrNoSelection:

  const rdrNoSelection = useMemo(
    () => {
      const range = ranges?.[0];
      return !range || (range.startDate === null && range.endDate === null);
    },
    [ranges]
  );
.rdrNoSelection {
  .rdrSelected, .rdrInRange, .rdrStartEdge, .rdrEndEdge {
    background: #fff;
  }

  .rdrDay:not(.rdrDayPassive) .rdrInRange ~ .rdrDayNumber span,
  .rdrDay:not(.rdrDayPassive) .rdrStartEdge ~ .rdrDayNumber span,
  .rdrDay:not(.rdrDayPassive) .rdrEndEdge ~ .rdrDayNumber span,
  .rdrDay:not(.rdrDayPassive) .rdrSelected ~ .rdrDayNumber span {
    color: $oa-black;

    &:after {
      background: $oa-blue;
    }
  }
}

bertho-zero avatar Nov 10 '20 08:11 bertho-zero

+1

smitser avatar Dec 01 '20 15:12 smitser

It's an old issue but is there any update?

stephaned-ev avatar Jun 03 '22 15:06 stephaned-ev