react-date-range icon indicating copy to clipboard operation
react-date-range copied to clipboard

Published 20 hours ago • verified publisher icon hypeserver

feature/improve_mobile_experience

Open mithrand opened this issue 6 years ago • 2 comments

Types of changes

What types of changes does your code introduce?

improve experience on mobile devices.

Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

I have added touchstart to the list of event listener, it will treated in the same way that a mouseup event.

mithrand avatar Jun 07 '18 15:06 mithrand

Hi @mithrand I tested your pr with mobile phone but it seems touch events are causing trouble although your adjustment.

mkg0 avatar Jun 19 '18 08:06 mkg0

Hi @mkg0 . Is any other way in which you can include touch events? Maybe trying to detect if the event of onTouchStart/onMouseUp is coming from desktop or mobile? We would need this working on mobile too, that was the reason we added the touchstart.

mlacif1 avatar Aug 31 '18 07:08 mlacif1