Igor [hyperxor]

Results 11 comments of Igor [hyperxor]

@dennisjenkins75 Hello, Travis CI doesn't run anymore?

@dennisjenkins75 @Inux Hello, please, take a look at my pull request https://github.com/oktal/pistache/pull/746

Hello, @iroddis, can you describe the expected scenario of the `client_multiple_requests_disconnects_handled` unit test, maybe I can fix it.

@dennisjenkins75 Ok, thank you, I will see. ``` $ uname -a Linux hyperxor-ws 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux $ g++ --version g++...

@dennisjenkins75 @kiplingw I have found tbe same problem with tests [here](https://launchpadlibrarian.net/508540260/buildlog_ubuntu-focal-arm64.pistache_0.0.002-202011242302~ubuntu20.04.1_BUILDING.txt.gz) - arm64 build of pistache 0.0.002-202011242302~ubuntu20.04.1 in ubuntu focal RELEASE ([link](https://launchpad.net/~pistache+team/+archive/ubuntu/unstable/+build/20332466)): ``` [ RUN ] http_server_test.client_multiple_requests_disconnects_handled Trying to run...

@dennisjenkins75 I will close this issue in you don't mind. Fix is working.

@kiplingw Hello, can you send build fails (if any) on `http_server_test.client_multiple_requests_disconnects_handled` test to this isssue? I think latest changes will help to find root cause of problem.

@kiplingw I think this issue can be closed if there are no bug reproductions.

@handrews42 Hello, I have made several changes (they are in master) to fix this bug. Would it be possible for you to check it? @dennisjenkins75

@bradyguyer I'm not sure, but I think I cannot agree with you. In this case`Pistache::Http::ResponseWriter` object is passed by value using move semantics: `onRequest` [`std::move(resp)`] -> `route` [`std::move(response)`] -> `invokeHandler`...