javaagent icon indicating copy to clipboard operation
javaagent copied to clipboard

Discrepancy with respect to OTel semantics in db call span

Open findingrish opened this issue 4 years ago • 6 comments

The semantics mandate the presence of net.peer.name or net.peer.ip and conditionally net.peer.port attributes. These attributes are absent in the span reported by HT Java agent

Attaching the screen shot for a span. Screenshot 2020-12-05 at 6 53 35 PM

cc @pavolloffay @davexroth

findingrish avatar Dec 05 '20 17:12 findingrish

Also, according to the Otel semantics the key for Span kind is span_kind

findingrish avatar Dec 05 '20 17:12 findingrish

@rish691 could you please provide link/quote to spec where it mandates these attributes? Is it here https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md

Also, according to the Otel semantics the key for Span kind is span_kind

I assume the OTEL agent uses span_kind but then it gets converted to span.span in the OC service (collector). The platform should support span.kind orthogonally to this since it's a widely used tag.

pavolloffay avatar Dec 07 '20 07:12 pavolloffay

Additional attribute requirements: At least one of the following sets of attributes is required: net.peer.name net.peer.ip

findingrish avatar Dec 07 '20 07:12 findingrish

Tracked upstream in https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/1521

pavolloffay avatar Dec 07 '20 07:12 pavolloffay

I have a pr on the platform to handle this. So, this issue shouldn't block our testing at the moment.

findingrish avatar Dec 07 '20 09:12 findingrish

I belive the change - https://github.com/hypertrace/hypertrace-ingester/pull/84/files - is supposed to do workaround.

kotharironak avatar Dec 14 '20 09:12 kotharironak