javaagent
javaagent copied to clipboard
Discrepancy with respect to OTel semantics in db call span
The semantics mandate the presence of net.peer.name
or net.peer.ip
and conditionally net.peer.port
attributes.
These attributes are absent in the span reported by HT Java agent
Attaching the screen shot for a span.
cc @pavolloffay @davexroth
Also, according to the Otel semantics the key for Span kind is span_kind
@rish691 could you please provide link/quote to spec where it mandates these attributes? Is it here https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/database.md
Also, according to the Otel semantics the key for Span kind is span_kind
I assume the OTEL agent uses span_kind
but then it gets converted to span.span
in the OC service (collector). The platform should support span.kind
orthogonally to this since it's a widely used tag.
Additional attribute requirements: At least one of the following sets of attributes is required: net.peer.name net.peer.ip
Tracked upstream in https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/1521
I have a pr on the platform to handle this. So, this issue shouldn't block our testing at the moment.
I belive the change - https://github.com/hypertrace/hypertrace-ingester/pull/84/files - is supposed to do workaround.