hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

feat: add option to persist modal across navigation changes

Open jake-bassett opened this issue 2 years ago • 2 comments

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

jake-bassett avatar Nov 28 '23 01:11 jake-bassett

Test Results

       4 files     316 suites   31m 54s :stopwatch: 1 135 tests 1 135 :heavy_check_mark: 0 :zzz: 0 :x: 1 145 runs  1 145 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 0547756b.

github-actions[bot] avatar Nov 28 '23 01:11 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2a0fe4e) 82.99% compared to head (0547756) 82.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2545   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         925      925           
  Lines       20628    20629    +1     
  Branches     3253     3254    +1     
=======================================
+ Hits        17120    17121    +1     
  Misses       3388     3388           
  Partials      120      120           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 01:11 codecov[bot]