hypertrace-ui
hypertrace-ui copied to clipboard
refactor: using subscription lifecycle or take(1) where necessary
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] Any dependent changes have been merged and published in downstream modules
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.
Codecov Report
Merging #2495 (ecfadf0) into main (d2dd2b4) will increase coverage by
0.00%
. Report is 5 commits behind head on main. The diff coverage is97.77%
.
@@ Coverage Diff @@
## main #2495 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 925 925
Lines 20610 20622 +12
Branches 3254 3254
=======================================
+ Hits 17119 17130 +11
- Misses 3372 3373 +1
Partials 119 119
Files | Coverage Δ | |
---|---|---|
...nents/src/download-file/download-file.component.ts | 100.00% <100.00%> (ø) |
|
...ts/components/src/select/select-group.component.ts | 100.00% <100.00%> (ø) |
|
...mponents/src/table/table-csv-downloader.service.ts | 89.47% <100.00%> (ø) |
|
projects/components/src/table/table.component.ts | 79.95% <100.00%> (+0.04%) |
:arrow_up: |
...ore-query-editor/explore-query-editor.component.ts | 97.82% <100.00%> (+0.15%) |
:arrow_up: |
...roup-by/explore-query-group-by-editor.component.ts | 97.82% <100.00%> (+0.09%) |
:arrow_up: |
...timeline-card-list/timeline-card-list.component.ts | 100.00% <100.00%> (ø) |
|
...d-wrapper/application-aware-dashboard.component.ts | 82.85% <100.00%> (+0.50%) |
:arrow_up: |
projects/dashboards/src/widgets/widget-renderer.ts | 85.71% <75.00%> (-2.53%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Unit Test Results
4 files 316 suites 49m 23s :stopwatch: 1 131 tests 1 131 :heavy_check_mark: 0 :zzz: 0 :x: 1 141 runs 1 141 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit ecfadf0a.