hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

Replacing group by with interval as none chart

Open palbizu opened this issue 2 years ago • 4 comments

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

palbizu avatar Oct 17 '23 16:10 palbizu

Unit Test Results

       4 files     309 suites   49m 6s :stopwatch: 1 122 tests 1 120 :heavy_check_mark: 0 :zzz: 2 :x: 1 132 runs  1 130 :heavy_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit fe3e9b0e.

github-actions[bot] avatar Oct 17 '23 16:10 github-actions[bot]

Codecov Report

Merging #2470 (c30ae30) into main (2c52154) will decrease coverage by 26.16%. Report is 2 commits behind head on main. The diff coverage is 5.88%.

:exclamation: Current head c30ae30 differs from pull request most recent head 2a92be5. Consider uploading reports for the commit 2a92be5 to get more accurate results

@@             Coverage Diff             @@
##             main    #2470       +/-   ##
===========================================
- Coverage   83.02%   56.87%   -26.16%     
===========================================
  Files         916      916               
  Lines       20474    20483        +9     
  Branches     3238     3249       +11     
===========================================
- Hits        16999    11649     -5350     
- Misses       3356     8448     +5092     
- Partials      119      386      +267     
Files Coverage Δ
...y/src/pages/explorer/explorer-dashboard-builder.ts 15.29% <ø> (-63.53%) :arrow_down:
...arts/cartesian-widget/axis/cartesian-axis.model.ts 80.00% <100.00%> (+2.22%) :arrow_up:
.../components/cartesian/cartesian-chart.component.ts 10.00% <0.00%> (-51.25%) :arrow_down:
...hql/explore/explore-cartesian-data-source.model.ts 17.14% <0.00%> (-67.37%) :arrow_down:
...ents/cartesian/d3/axis/cartesian-axis-crosshair.ts 4.00% <0.00%> (-5.59%) :arrow_down:
...nents/cartesian/d3/data/series/cartesian-column.ts 11.84% <0.00%> (-63.53%) :arrow_down:

... and 208 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 17 '23 16:10 codecov[bot]

Unit Test Results

       4 files     309 suites   50m 19s :stopwatch: 1 122 tests 1 120 :heavy_check_mark: 0 :zzz: 2 :x: 1 132 runs  1 130 :heavy_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit c30ae302.

github-actions[bot] avatar Oct 17 '23 16:10 github-actions[bot]

Unit Test Results

       4 files     315 suites   51m 10s :stopwatch: 1 130 tests 1 128 :heavy_check_mark: 0 :zzz: 2 :x: 1 140 runs  1 138 :heavy_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit 2a92be5a.

github-actions[bot] avatar Oct 19 '23 15:10 github-actions[bot]