hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

feat: adding query param support in nav links

Open anandtiwary opened this issue 1 year ago • 2 comments

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

anandtiwary avatar Mar 23 '23 20:03 anandtiwary

Codecov Report

Merging #2090 (5ba552c) into main (63f43c3) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   83.12%   83.11%   -0.01%     
==========================================
  Files         905      905              
  Lines       19953    19954       +1     
  Branches     2858     2858              
==========================================
  Hits        16585    16585              
- Misses       3217     3218       +1     
  Partials      151      151              
Impacted Files Coverage Δ
...ents/src/navigation/nav-item/nav-item.component.ts 87.50% <0.00%> (-5.84%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Mar 23 '23 20:03 codecov[bot]

Unit Test Results

       4 files  ±0     304 suites  ±0   24m 20s :stopwatch: -1s 1 093 tests ±0  1 093 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 101 runs  ±0  1 101 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 5ba552ce. ± Comparison against base commit 63f43c3a.

github-actions[bot] avatar Mar 23 '23 20:03 github-actions[bot]