hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

refactor: only render active stepper content

Open anandtiwary opened this issue 2 years ago • 2 comments

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

anandtiwary avatar Jan 26 '23 21:01 anandtiwary

Codecov Report

Merging #2015 (0a53fd7) into main (683fe59) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   83.13%   83.08%   -0.05%     
==========================================
  Files         900      903       +3     
  Lines       19758    19804      +46     
  Branches     2806     2823      +17     
==========================================
+ Hits        16426    16455      +29     
- Misses       3183     3198      +15     
- Partials      149      151       +2     
Impacted Files Coverage Δ
...ojects/components/src/stepper/stepper.component.ts 79.03% <ø> (ø)
projects/components/src/select/select.component.ts 81.25% <100.00%> (ø)
...hql/table/entity/entity-table-data-source.model.ts 69.23% <0.00%> (-15.15%) :arrow_down:
...components/src/table/data/table-cdk-data-source.ts 71.68% <0.00%> (-3.16%) :arrow_down:
...able/columns/table-edit-columns-modal.component.ts 15.00% <0.00%> (-1.67%) :arrow_down:
projects/common/src/time/time.ts 100.00% <0.00%> (ø)
projects/common/src/utilities/validators/index.ts 100.00% <0.00%> (ø)
projects/components/src/button/button.component.ts 100.00% <0.00%> (ø)
...ojects/common/src/utilities/angular/pipes/index.ts 100.00% <0.00%> (ø)
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <0.00%> (ø)
... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jan 26 '23 21:01 codecov[bot]

Unit Test Results

       4 files  ±0     304 suites  ±0   24m 0s :stopwatch: - 1m 42s 1 084 tests ±0  1 084 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 092 runs  ±0  1 092 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 0a53fd77. ± Comparison against base commit 65acab88.

github-actions[bot] avatar Jan 26 '23 21:01 github-actions[bot]