hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

feat(stepper): explicit disabling of stepper controls

Open adisreyaj opened this issue 2 years ago • 5 comments

Adds support for explicitly disabling stepper control buttons:

  • Back
  • Cancel
  • Next
  • Submit

Use-case: One common use case, is to disable the Submit button when data is getting saved.

adisreyaj avatar Oct 17 '22 09:10 adisreyaj

Unit Test Results

       4 files  ±0     297 suites  ±0   22m 56s :stopwatch: + 1m 40s 1 072 tests +4  1 072 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0  1 080 runs  +4  1 080 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0 

Results for commit 1da0c553. ± Comparison against base commit d26841d8.

github-actions[bot] avatar Oct 17 '22 09:10 github-actions[bot]

Codecov Report

Merging #1870 (1da0c55) into main (d26841d) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   83.36%   83.37%   +0.01%     
==========================================
  Files         886      886              
  Lines       19375    19387      +12     
  Branches     2731     2734       +3     
==========================================
+ Hits        16151    16163      +12     
  Misses       3084     3084              
  Partials      140      140              
Impacted Files Coverage Δ
...ojects/components/src/stepper/stepper.component.ts 87.14% <100.00%> (+2.66%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 17 '22 09:10 codecov[bot]

Why do we want to be disabling back and cancel?

23nobody avatar Oct 17 '22 09:10 23nobody

it’ll be better if we can bake this config onto the stepper tab component as individual controls so that change detection can be leveraged

arjunlalb avatar Oct 17 '22 09:10 arjunlalb

Why do we want to be disabling back and cancel?

Future proofing.

adisreyaj avatar Oct 17 '22 09:10 adisreyaj