hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

refactor: returning empty array when toggledRow is undefined

Open anandtiwary opened this issue 2 years ago • 2 comments

Description

Please include a summary of the change, motivation and context. refactor: returning empty array when toggledRow is undefined

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

anandtiwary avatar Jun 30 '22 21:06 anandtiwary

Codecov Report

Merging #1726 (240b74a) into main (2bfd8c1) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1726   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files         890      890           
  Lines       19170    19172    +2     
  Branches     2640     2642    +2     
=======================================
+ Hits        16055    16057    +2     
  Misses       2982     2982           
  Partials      133      133           
Impacted Files Coverage Δ
projects/components/src/table/table.component.ts 85.95% <0.00%> (ø)
...mon/src/time/page-time-range-preference.service.ts 92.50% <0.00%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bfd8c1...240b74a. Read the comment docs.

codecov[bot] avatar Jun 30 '22 22:06 codecov[bot]

Unit Test Results

       4 files  ±0     299 suites  ±0   24m 39s :stopwatch: + 2m 2s 1 063 tests ±0  1 063 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  1 071 runs  ±0  1 071 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 240b74a5. ± Comparison against base commit 8c7c18b6.

github-actions[bot] avatar Jun 30 '22 22:06 github-actions[bot]