hypertrace-ui
hypertrace-ui copied to clipboard
fix: loader should hide the columns
fix: loader should hide the columns
- Also fixed double table render during the initial load
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] Any dependent changes have been merged and published in downstream modules
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.
@Christian862 i think this will solve the skeleton loader table issue.
Codecov Report
Merging #1485 (7747813) into main (e363a01) will decrease coverage by
33.16%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #1485 +/- ##
===========================================
- Coverage 83.69% 50.52% -33.17%
===========================================
Files 873 873
Lines 18915 18912 -3
Branches 2603 2603
===========================================
- Hits 15831 9556 -6275
- Misses 2950 8945 +5995
- Partials 134 411 +277
Impacted Files | Coverage Δ | |
---|---|---|
projects/components/src/table/table.component.ts | 59.16% <0.00%> (-26.79%) |
:arrow_down: |
src/app/home/home.module.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
src/app/home/home.component.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
src/app/home/home.dashboard.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...ata/label/total-errors-label-data-source.module.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...a/system/observe-system-radar-data-source.model.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
.../system/observe-system-radar-data-source.module.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...src/widgets/link/link-widget-renderer.component.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
...ed/components/topology/utils/topology-converter.ts | 2.56% <0.00%> (-97.44%) |
:arrow_down: |
.../utils/resolver/graphql-request-option-resolver.ts | 5.55% <0.00%> (-94.45%) |
:arrow_down: |
... and 354 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e363a01...7747813. Read the comment docs.
Unit Test Results
4 files ±0 284 suites ±0 21m 31s :stopwatch: + 1m 35s 1 014 tests ±0 1 008 :heavy_check_mark: - 6 0 :zzz: ±0 6 :x: +6 1 022 runs ±0 1 015 :heavy_check_mark: - 7 0 :zzz: ±0 7 :x: +7
For more details on these failures, see this check.
Results for commit 61fd98ca. ± Comparison against base commit 5fd07f60.
@jake-bassett Could you also review this once?
Unit Test Results
4 files ±0 290 suites ±0 23m 23s :stopwatch: -46s 1 045 tests ±0 1 038 :heavy_check_mark: - 7 0 :zzz: ±0 7 :x: +7 1 053 runs ±0 1 045 :heavy_check_mark: - 8 0 :zzz: ±0 8 :x: +8
For more details on these failures, see this check.
Results for commit 4fe4fd90. ± Comparison against base commit f479541a.
Unit Test Results
4 files ±0 290 suites ±0 21m 3s :stopwatch: -54s 1 045 tests ±0 1 038 :heavy_check_mark: - 7 0 :zzz: ±0 7 :x: +7 1 053 runs ±0 1 045 :heavy_check_mark: - 8 0 :zzz: ±0 8 :x: +8
For more details on these failures, see this check.
Results for commit 7747813c. ± Comparison against base commit e363a01c.