hypertrace-ui
hypertrace-ui copied to clipboard
Add Nx build tool to Hypertrace UI
Description
Please include a summary of the change, motivation, and context. Migrating Hypertrace to NX
- Using NX 12
- Staying on Tslint for now. Separate PR will be created for migration to ESLint
- Renamed
projects
tolibs
to go with nx standard - Each lib is now a light-weight buildable library using ng-packagr-lite
- Ng serve will source compile and run all lib files instead of building them as a separate library. This is OOTB with NX
- Migrated jest to the newer version. Fixed all test errors.
- Added relevant code for the
affected
command. I will propose and create a separate PR for using this in PR build mode - Since tests are now split at the lib boundary, I had to remove the existing test batching (which requires all tests to be run via the test app command). Will revisit and bring back this intelligent test batching with a future pr.
- NX cloud is enabled (since
ht-ui
is an OS project) - Please run
nx affected:*
command to only run the command in projects with the dependent code changes. This will save time! - Easy-to-use npm scripts are also added.
- Caching is disabled in CI as of now.
Future PRs:
- migrate to eslint
- migrate to the latest version of NX. This will also migrate to the latest versions of dependent libs like angular, jest, eslint etc
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] Any dependent changes have been merged and published in downstream modules
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.
Unit Test Results
0 files - 4 0 suites - 276 0s :stopwatch: - 22m 49s 0 tests - 982 0 :heavy_check_mark: - 982 0 :zzz: ±0 0 :x: ±0 0 runs - 989 0 :heavy_check_mark: - 989 0 :zzz: ±0 0 :x: ±0
Results for commit 0336dfd6. ± Comparison against base commit f51440a6.
Unit Test Results
0 files - 4 0 suites - 280 0s :stopwatch: - 22m 49s 0 tests - 1 004 0 :heavy_check_mark: - 1 004 0 :zzz: ±0 0 :x: ±0 0 runs - 1 012 0 :heavy_check_mark: - 1 012 0 :zzz: ±0 0 :x: ±0
Results for commit 7443e272. ± Comparison against base commit a907ecbf.
Unit Test Results
28 files +24 275 suites - 5 30m 25s :stopwatch: + 7m 36s 995 tests - 9 995 :heavy_check_mark: - 9 0 :zzz: ±0 0 :x: ±0 1 002 runs - 10 1 002 :heavy_check_mark: - 10 0 :zzz: ±0 0 :x: ±0
Results for commit ce61c659. ± Comparison against base commit a907ecbf.
Unit Test Results
32 files +28 280 suites ±0 31m 39s :stopwatch: + 8m 50s 1 002 tests - 2 1 002 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 010 runs - 2 1 010 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit e9c84b69. ± Comparison against base commit a907ecbf.
Unit Test Results
32 files +28 276 suites - 8 24m 58s :stopwatch: + 3m 37s 997 tests - 17 997 :heavy_check_mark: - 17 0 :zzz: ±0 0 :x: ±0 1 003 runs - 19 1 003 :heavy_check_mark: - 19 0 :zzz: ±0 0 :x: ±0
Results for commit d6f31bec. ± Comparison against base commit d5c720e7.
Unit Test Results
0 files - 4 0 suites - 296 0s :stopwatch: - 21m 5s 0 tests - 1 055 0 :heavy_check_mark: - 1 055 0 :zzz: ±0 0 :x: ±0 0 runs - 1 063 0 :heavy_check_mark: - 1 063 0 :zzz: ±0 0 :x: ±0
Results for commit ac493e1b. ± Comparison against base commit 861c552d.
Unit Test Results
0 files - 4 0 suites - 296 0s :stopwatch: - 21m 5s 0 tests - 1 055 0 :heavy_check_mark: - 1 055 0 :zzz: ±0 0 :x: ±0 0 runs - 1 063 0 :heavy_check_mark: - 1 063 0 :zzz: ±0 0 :x: ±0
Results for commit fb3b3605. ± Comparison against base commit 861c552d.
Unit Test Results
8 files +4 296 suites ±0 20m 15s :stopwatch: -50s 1 053 tests - 2 1 053 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 061 runs - 2 1 061 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit ede66037. ± Comparison against base commit 861c552d.
Codecov Report
Merging #1358 (acef77b) into main (a9be616) will decrease coverage by
2.97%
. The diff coverage is87.50%
.
@@ Coverage Diff @@
## main #1358 +/- ##
==========================================
- Coverage 83.13% 80.17% -2.97%
==========================================
Files 905 905
Lines 19904 19623 -281
Branches 2841 3036 +195
==========================================
- Hits 16548 15732 -816
- Misses 3205 3746 +541
+ Partials 151 145 -6
Impacted Files | Coverage Δ | |
---|---|---|
...p/application-frame/application-frame.component.ts | 0.00% <ø> (ø) |
|
.../app/application-frame/application-frame.module.ts | 0.00% <ø> (ø) |
|
apps/hypertrace-ui/src/app/config.module.ts | 0.00% <ø> (ø) |
|
apps/hypertrace-ui/src/app/entity-metadata.ts | 0.00% <ø> (ø) |
|
...data/label/total-errors-label-data-source.model.ts | 100.00% <ø> (ø) |
|
...ata/label/total-errors-label-data-source.module.ts | 100.00% <ø> (ø) |
|
...a/system/observe-system-radar-data-source.model.ts | 100.00% <ø> (ø) |
|
.../system/observe-system-radar-data-source.module.ts | 100.00% <ø> (ø) |
|
apps/hypertrace-ui/src/app/home/home.component.ts | 100.00% <ø> (ø) |
|
apps/hypertrace-ui/src/app/home/home.dashboard.ts | 100.00% <ø> (ø) |
|
... and 1735 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Unit Test Results
8 files +4 296 suites ±0 20m 47s :stopwatch: -18s 1 053 tests - 2 1 053 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 061 runs - 2 1 061 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 9b225327. ± Comparison against base commit 861c552d.
Unit Test Results
8 files +4 296 suites ±0 25m 55s :stopwatch: + 4m 50s 1 053 tests - 2 1 053 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 061 runs - 2 1 061 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 1aa78933. ± Comparison against base commit 861c552d.
Unit Test Results
8 files + 4 185 suites - 114 5m 43s :stopwatch: - 15m 47s 742 tests - 322 742 :heavy_check_mark: - 322 0 :zzz: ±0 0 :x: ±0 744 runs - 328 744 :heavy_check_mark: - 328 0 :zzz: ±0 0 :x: ±0
Results for commit 53ebeb8a. ± Comparison against base commit 2887f5a9.
Unit Test Results
0 files - 4 0 suites - 295 0s :stopwatch: - 23m 1s 0 tests - 1 060 0 :heavy_check_mark: - 1 060 0 :zzz: ±0 0 :x: ±0 0 runs - 1 068 0 :heavy_check_mark: - 1 068 0 :zzz: ±0 0 :x: ±0
Results for commit e7ed482f. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 20m 24s :stopwatch: - 2m 37s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 353fe7fa. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 20m 24s :stopwatch: - 2m 37s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 271c0ba9. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 26m 0s :stopwatch: + 2m 59s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit fe90679c. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 19m 3s :stopwatch: - 3m 58s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 8d9fe2a8. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 23m 7s :stopwatch: +6s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 6f787389. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 23m 53s :stopwatch: +52s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 7bcc3b1f. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 26m 19s :stopwatch: + 3m 18s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 797705d8. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 20m 58s :stopwatch: - 2m 3s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit ae6acd6e. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 20m 58s :stopwatch: - 2m 3s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 9a2d44ec. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 27m 22s :stopwatch: + 4m 21s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit cee308b4. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 24m 58s :stopwatch: + 1m 57s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 570edbce. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files +4 295 suites ±0 21m 10s :stopwatch: - 1m 51s 1 058 tests - 2 1 058 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 066 runs - 2 1 066 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 3cb3f473. ± Comparison against base commit 2e37eb4b.
Unit Test Results
8 files 295 suites 24m 17s :stopwatch: 1 059 tests 1 059 :heavy_check_mark: 0 :zzz: 0 :x: 1 067 runs 1 067 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 096eaa58.
Unit Test Results
8 files 295 suites 23m 7s :stopwatch: 1 059 tests 1 059 :heavy_check_mark: 0 :zzz: 0 :x: 1 067 runs 1 067 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit d0723151.
Unit Test Results
8 files 295 suites 19m 49s :stopwatch: 1 059 tests 1 059 :heavy_check_mark: 0 :zzz: 0 :x: 1 067 runs 1 067 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 96094611.
Unit Test Results
8 files 295 suites 25m 53s :stopwatch: 1 059 tests 1 059 :heavy_check_mark: 0 :zzz: 0 :x: 1 067 runs 1 067 :heavy_check_mark: 0 :zzz: 0 :x:
Results for commit 96094611.
Unit Test Results
8 files +4 296 suites ±0 19m 41s :stopwatch: - 3m 3s 1 060 tests - 2 1 060 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0 1 068 runs - 2 1 068 :heavy_check_mark: - 2 0 :zzz: ±0 0 :x: ±0
Results for commit 422bf8c3. ± Comparison against base commit e62692f6.