hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

Start Time and End Time filters doesn’t show invalid input message in explorer

Open jyothishjose6190 opened this issue 3 years ago • 3 comments

Guessing that they are doing some internal validation Any incorrect input should show some toast with validation error details. Screenshot 2021-11-24 at 9 05 46 AM

jyothishjose6190 avatar Nov 23 '21 08:11 jyothishjose6190

Can you elaborate? What's not working? This screenshot looks to be on the trace list of an endpoint rather than explorer (although they work more or less the same way).

We don't frequently filter by these explicitly since we instead adjust the time range, but they should work and did when I just tested locally. They're pretty inconvenient since working with the attributes directly like that means you're working in their native format, epoch millis.

image

aaron-steinfeld avatar Nov 23 '21 13:11 aaron-steinfeld

@aaron-steinfeld when we enter invalid input, for example, start time filter without any value, it's not showing any error message. is it the expected behavior? Screenshot 2021-11-24 at 9 05 46 AM

jyothishjose6190 avatar Nov 24 '21 03:11 jyothishjose6190

It's the implemented behavior for all filters (if the filter is left in an incomplete/invalid state, it's left that way to be finished later), but agree the UX isn't great. Do you mind updating this ticket to capture this general improvement?

aaron-steinfeld avatar Nov 30 '21 01:11 aaron-steinfeld