hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

feat: support for showing labels in toggle component

Open arjunlalb opened this issue 3 years ago • 3 comments

Description

support for showing labels in toggle component

Screenshot 2021-11-04 at 9 53 11 PM

Testing

Locally verified. UT updated.

Checklist:

  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] Any dependent changes have been merged and published in downstream modules

arjunlalb avatar Nov 04 '21 16:11 arjunlalb

Unit Test Results

    4 files  ±0  272 suites  ±0   18m 46s :stopwatch: +5s 973 tests ±0  973 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  980 runs  ±0  980 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f43715a4. ± Comparison against base commit f06a7a59.

github-actions[bot] avatar Nov 04 '21 16:11 github-actions[bot]

Codecov Report

Merging #1234 (3638af9) into main (f06a7a5) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   84.73%   84.74%           
=======================================
  Files         833      833           
  Lines       17383    17387    +4     
  Branches     2277     2277           
=======================================
+ Hits        14730    14734    +4     
  Misses       2619     2619           
  Partials       34       34           
Impacted Files Coverage Δ
...ponents/src/toggle-group/toggle-group.component.ts 89.74% <ø> (ø)
...components/src/toggle-group/toggle-group.module.ts 100.00% <100.00%> (ø)
...mponents/src/toggle-group/toggle-item.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f06a7a5...3638af9. Read the comment docs.

codecov[bot] avatar Nov 04 '21 16:11 codecov[bot]

Unit Test Results

    4 files  ±0  272 suites  ±0   18m 22s :stopwatch: -19s 973 tests ±0  973 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  980 runs  ±0  980 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 3638af99. ± Comparison against base commit f06a7a59.

github-actions[bot] avatar Nov 04 '21 16:11 github-actions[bot]