valkey-operator icon indicating copy to clipboard operation
valkey-operator copied to clipboard

Generate OLM Bundle for OperatorHub Release

Open MuneebAijaz opened this issue 10 months ago • 5 comments

Refers to: https://github.com/hyperspike/valkey-operator/issues/72

MuneebAijaz avatar Feb 12 '25 19:02 MuneebAijaz

@dmolik Hi, i have some questions here, $(VERSION) calculation in Makefile currently returns commit hash, can we support git tags there?

While setting up the project, i do get this error while running generators build constraints exclude all Go files in /usr/local/go/src/iter, I need guidance on how to set it up properly.

MuneebAijaz avatar Feb 12 '25 19:02 MuneebAijaz

Hey @MuneebAijaz $(VERSION) does support git tags, the behavior is when HEAD matches a tag VERSION is the tag name so if you checkout v0.0.55, $(VERSION) will be v0.0.55. However on any given day HEAD is likely to be untaggged, so VERSION will be the short sha of the most recent commit. There is all so another variable $(SHA) which always gives the most recent short commit sha.

You're other error looks to be related to your go setup, what's $GOROOT and $GOPATH set to?

Sorry for the late response, I've been violently ill this week.

Finally keep up the good work!

dmolik avatar Feb 14 '25 18:02 dmolik

@dmolik i had some questions about how the operator works, and how can i test it. i saw theres some link in instance name and config maps?

MuneebAijaz avatar Feb 25 '25 17:02 MuneebAijaz

Is there anything missing? Or is it only the maintainers having to find time to properly review?

ibotty avatar Jul 21 '25 07:07 ibotty

@ibotty its waiting on review

MuneebAijaz avatar Jul 28 '25 11:07 MuneebAijaz