Lightbox icon indicating copy to clipboard operation
Lightbox copied to clipboard

Delete image

Open MagicFlow29 opened this issue 4 years ago • 3 comments

Step 1 - enable delete button: LightboxConfig.DeleteButton.enabled = true

Step 2 - Delete:

Crash on: let pageView = pageViews[i] in:

  func reconfigurePagesForPreload() {
    let preloadIndicies = calculatePreloadIndicies()

    for i in 0..<initialImages.count {
      let pageView = pageViews[i]
      if preloadIndicies.contains(i) {
        if type(of: pageView.image) == LightboxImageStub.self {
          pageView.update(with: initialImages[i])
        }
      } else {
        if type(of: pageView.image) != LightboxImageStub.self {
          pageView.update(with: LightboxImageStub())
        }
      }
}

}

MagicFlow29 avatar Dec 20 '20 19:12 MagicFlow29

Fixed by adding the following line: self.initialImages.remove(at: prevIndex)

to func headerView(_ headerView: HeaderView, didPressDeleteButton deleteButton: UIButton) {

noting the above function is also lacking a delegate

MagicFlow29 avatar Dec 20 '20 20:12 MagicFlow29

This fix is already in this pull request - https://github.com/hyperoslo/Lightbox/pull/265 I think the repo maintainer just have to release new version.

alexandrgl avatar Jan 22 '21 13:01 alexandrgl

Ok! New version coming

3lvis avatar Jan 30 '21 06:01 3lvis