Compass icon indicating copy to clipboard operation
Compass copied to clipboard

Support regular urls that have a path component

Open pferruggiaro opened this issue 9 years ago • 5 comments

Constructs the Location.path based on the URL.host + URL.path, so that URLs such as scheme://callback/path are supported.

pferruggiaro avatar Nov 02 '16 16:11 pferruggiaro

@pferruggiaro, thanks for your PR! By analyzing the history of the files in this pull request, we identified @onmyway133, @vadymmarkov and @zenangst to be potential reviewers.

mention-bot avatar Nov 02 '16 16:11 mention-bot

This is great, thanks @pferruggiaro.

What do you guys think @hyperoslo/ios

zenangst avatar Nov 08 '16 17:11 zenangst

I like it @pferruggiaro

vadymmarkov avatar Nov 08 '16 17:11 vadymmarkov

Last time we support delimiter https://github.com/hyperoslo/Compass/blob/master/Sources/Compass.swift#L12 so that people don't have to to use the default :

@pferruggiaro is this what you mean?

onmyway133 avatar Nov 08 '16 21:11 onmyway133

@onmyway133 Possibly... I can see how switching the delimiter to / would enable a URL like user/list/{userId}/{kind}, but my goal is to support a standard URL that includes a host, path, and query params such as targetapp://x-callback-url/updateStatus?x-source=SourceApp&text=test123

pferruggiaro avatar Nov 08 '16 22:11 pferruggiaro