web3j icon indicating copy to clipboard operation
web3j copied to clipboard

Calculate baseFeePerBlobGas value

Open NickSneo opened this issue 1 year ago • 2 comments

What does this PR do?

Add a new feature to get baseFeePerBlobGas value

Where should the reviewer start?

review all files, start with BlobFee.java file

Why is it needed?

required

NickSneo avatar Feb 16 '24 12:02 NickSneo

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (86c987d) 68.94% compared to head (ede5e8b) 69.20%. Report is 2 commits behind head on master.

Files Patch % Lines
...web3j/protocol/core/methods/response/EthBlock.java 82.45% 6 Missing and 4 partials :warning:
.../java/org/web3j/protocol/core/JsonRpc2_0Web3j.java 88.88% 2 Missing :warning:
...ocol/core/methods/response/TransactionReceipt.java 94.11% 2 Missing :warning:
...3j/protocol/core/methods/response/Transaction.java 97.87% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2006      +/-   ##
============================================
+ Coverage     68.94%   69.20%   +0.25%     
- Complexity     3089     3117      +28     
============================================
  Files           493      493              
  Lines         12922    13078     +156     
  Branches       1661     1688      +27     
============================================
+ Hits           8909     9050     +141     
- Misses         3526     3537      +11     
- Partials        487      491       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 16 '24 12:02 codecov[bot]

which version will include this feature?

GrapeBaBa avatar Feb 19 '24 05:02 GrapeBaBa

which version will include this feature?

We will be releasing it in next release 4.11.1

NickSneo avatar Feb 19 '24 09:02 NickSneo

LGTM

cfelde avatar Feb 20 '24 09:02 cfelde

which version will include this feature?

We will be releasing it in next release 4.11.1

When will 4.11.1 release? We need 4844 support Dencun upgrade.

GrapeBaBa avatar Feb 23 '24 10:02 GrapeBaBa

which version will include this feature?

We will be releasing it in next release 4.11.1

When will 4.11.1 release? We need 4844 support Dencun upgrade.

Should be complete by next week, we need to add other things in web3j-cli and want to release everything together. Also since web3j is now migrating to Hyperledger web3j, we will be making changes to all the repo and include it in 4.11.1 release

NickSneo avatar Feb 23 '24 11:02 NickSneo