solang icon indicating copy to clipboard operation
solang copied to clipboard

Duplicate code (part 2)

Open LucasSte opened this issue 2 years ago • 6 comments

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L493-L499

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L507-L516

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L550-L556

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L564-L573

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L607-L613

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L621-L630

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L664-L670

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/codegen/strength_reduce/expression_values.rs#L678-L687

========================================== 2. https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/helpers/fmt.rs#L201-L206

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/helpers/fmt.rs#L277-L282

=========================================== 3.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/format.rs#L255-L263

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/format.rs#L269-L277

=========================================== 4.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L75-L85

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L134-L144

=========================================== 5.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L420-L440

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/function_call.rs#L1759-L1779

============================================== 6.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/functions.rs#L137-L146

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/functions.rs#L695-L704

============================================== 7.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/functions.rs#L191-L212

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/variables.rs#L170-L192

==============================================

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L441-L452

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L516-L527

============================================== 9.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L492-L500

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L566-L573

============================================= 10.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L1022-L1026

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/instructions.rs#L1028-L1032

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L630-L636

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L674-L680

============================================= 12.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1037-L1043

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1089-L1095

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1101-L1106

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1119-L1124

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/solang-parser/src/lexer.rs#L1144-L1150

============================================= 13.

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/literals.rs#L46-L55

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/literals.rs#L112-L121

LucasSte avatar Apr 11 '23 18:04 LucasSte

Hello sir, Can I work on this ? It would be better if this could be assigned to me .

mihir1739 avatar Apr 18 '23 10:04 mihir1739

Fine by me

xermicus avatar Apr 18 '23 11:04 xermicus

Hey @mihir1739, we have not heard from you for more than a month. Please, let us know if you are still interested in working on this issue. If not, we'll deassign you from it so others can contribute.

LucasSte avatar May 29 '23 15:05 LucasSte